RNHTTR commented on code in PR #51253:
URL: https://github.com/apache/airflow/pull/51253#discussion_r2261161972
##########
providers/http/src/airflow/providers/http/triggers/http.py:
##########
@@ -18,19 +18,32 @@
import asyncio
import base64
+import importlib
+import inspect
import pickle
+import sys
from collections.abc import AsyncIterator
from importlib import import_module
from typing import TYPE_CHECKING, Any
import aiohttp
import requests
+from asgiref.sync import sync_to_async
from requests.cookies import RequestsCookieJar
from requests.structures import CaseInsensitiveDict
from airflow.exceptions import AirflowException
from airflow.providers.http.hooks.http import HttpAsyncHook
-from airflow.triggers.base import BaseTrigger, TriggerEvent
+from airflow.providers.http.version_compat import AIRFLOW_V_3_0_PLUS
+
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.triggers.base import BaseEventTrigger, BaseTrigger,
TriggerEvent
+else:
+ from airflow.triggers.base import ( # type: ignore
+ BaseTrigger,
+ BaseTrigger as BaseEventTrigger,
+ TriggerEvent,
+ )
Review Comment:
Should it be...
```python
from airflow.triggers.base import BaseTrigger, TriggerEvent
if AIRFLOW_V_3_0_PLUS:
from airflow.triggers.base import BaseEventTrigger
else:
from airflow.triggers.base import BaseTrigger as BaseEventTrigger
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
