pierrejeambrun commented on code in PR #53815:
URL: https://github.com/apache/airflow/pull/53815#discussion_r2262511442
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_pools.py:
##########
@@ -151,7 +192,7 @@ def test_should_respond_200(
body = response.json()
assert body["total_entries"] == expected_total_entries
- assert [pool["name"] for pool in body["pools"]] == expected_ids
+ assert sorted([pool["name"] for pool in body["pools"]]) ==
sorted(expected_ids)
Review Comment:
This is not the correct approach. Returned list should be deterministic and
we've been through specific efforts to implement that.
If no sort are specified, the resource primary key is used as a default
sorting.
Can you check why only this test has an issue, while other parametrized
tests did not seem to present this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
