potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3172884611
Hey @j178 -> I rebased/updated the draft PR to switch to `prek` -> https://github.com/apache/airflow/pull/54258 Also - while doing it, I found out that `prek` is prety nice name, because where we ambiguously used "precommits" or "pre-commits" - to describe our hooks, we now can simply use `prek hooks` - see my PR. This seems much better name and with the short `prek` tool name it feels way better than `pre-commit hooks` - also it's technically less ambiguous and correct because they could be `pre-push` hooks as well. I wrote about it at the airflow devlist: https://lists.apache.org/thread/coyrd1m103rpl5l8t9b9dcsow5qq049y The community seems to be largely in support of moving forward with `prek` - there were some lighthearted complaints about `prek` being too close to `pre-k` - which @notatallshaw explained before, but I also find it quite cool analogy. Somewhat `prek` is like a pre-kindergarden for PRs :D, so it's pretty appropriate. We prepn ared everyone so it won't be a surprise, we still discuss if `breze static checks` shoudl remain as wrapper (I would like to get rid of it), but generally it's eagerly awaited - for speed and later better organization of our pre-commits. I think what we really miss now to complete the transition: * autocomplete is merged but seems `COMPLETE=zsh prek` does not produce the right auto-complete but it runs the hooks * pygrep support (as you mentioned) * maybe good thing would be a `list` command - https://github.com/j178/prek/issues/418 Other than that - I see it **almost** there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
