HsiuChuanHsu commented on code in PR #54115:
URL: https://github.com/apache/airflow/pull/54115#discussion_r2265525043
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_types.py:
##########
@@ -31,11 +31,15 @@
# TaskInstance key, command, configuration, pod_template_file
KubernetesJobType = tuple[TaskInstanceKey, CommandType, Any, str | None]
- # key, pod state, pod_name, namespace, resource_version
- KubernetesResultsType = tuple[TaskInstanceKey, TaskInstanceState | str |
None, str, str, str]
-
- # pod_name, namespace, pod state, annotations, resource_version
- KubernetesWatchType = tuple[str, str, TaskInstanceState | str | None,
dict[str, str], str]
+ # key, pod state, pod_name, namespace, resource_version, failure_details
+ KubernetesResultsType = tuple[
+ TaskInstanceKey, TaskInstanceState | str | None, str, str, str,
dict[str, Any] | None
Review Comment:
Agree! I've switched it to use a TypedDict for the failure details now. Much
safer than plain dicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
