Abhishek1559 commented on issue #54298: URL: https://github.com/apache/airflow/issues/54298#issuecomment-3174151047
Hi @Lee-W, That is correct, at FAB end, the function which is implemented from same BaseUser class, (where it is defined as def get_id(self) -> str: ...) is defined as def get_id(self): return self.id (located at providers/fab/src/airflow/providers/fab/auth_manager/models/__init__.py). There is no valid return type annotation mentioned as compared to implementation for other Auth services (ex. Amazon Auth manager, Simple auth, etc) where it is clearly defined with the return type annotations as string. Although it would not force a String value, it will make the code consistent across the code base. We can also have str(self.id) as the returning value. Should I go ahead and raise a PR with the same by adding the type annotation (or also include the type conversion as suggested)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
