amoghrajesh commented on code in PR #53393:
URL: https://github.com/apache/airflow/pull/53393#discussion_r2266609006
##########
airflow-core/tests/unit/utils/test_weight_rule.py:
##########
@@ -19,14 +19,7 @@
import pytest
-from airflow.utils.weight_rule import DB_SAFE_MAXIMUM, DB_SAFE_MINIMUM,
WeightRule, db_safe_priority
Review Comment:
All these tests can go in task sdk
##########
airflow-core/src/airflow/configuration.py:
##########
@@ -202,6 +203,28 @@ def retrieve_configuration_description(
return base_configuration_description
+class WeightRule(str, Enum):
+ """Weight rules."""
+
+ DOWNSTREAM = "downstream"
+ UPSTREAM = "upstream"
+ ABSOLUTE = "absolute"
+
+ @classmethod
+ def is_valid(cls, weight_rule: str) -> bool:
+ """Check if weight rule is valid."""
+ return weight_rule in cls.all_weight_rules()
+
+ @methodtools.lru_cache(maxsize=None)
+ @classmethod
+ def all_weight_rules(cls) -> set[str]:
+ """Return all weight rules."""
+ return set(cls.__members__.values())
+
+ def __str__(self) -> str:
+ return self.value
Review Comment:
This is only used in conf for `WeightRule.all_weight_rules()`, I wonder if
we would be better off if we just hardcoded it.
cc @ashb / @kaxil wdyt?
##########
devel-common/src/tests_common/test_utils/compat.py:
##########
@@ -63,7 +63,6 @@
# Compatibility for Airflow < 3.1
from airflow.utils.xcom import XCOM_RETURN_KEY # type:
ignore[no-redef,attr-defined]
-
Review Comment:
We can remove this change
##########
airflow-core/src/airflow/utils/weight_rule.py:
##########
@@ -1,56 +0,0 @@
-#
Review Comment:
Module members need to be deprecated, you need to add deprecation warning
for these. Example:
https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/utils/__init__.py#L23-L47
##########
airflow-core/tests/unit/utils/test_weight_rule.py:
##########
@@ -19,14 +19,7 @@
import pytest
-from airflow.utils.weight_rule import DB_SAFE_MAXIMUM, DB_SAFE_MINIMUM,
WeightRule, db_safe_priority
-
-
-def test_db_safe_priority():
- assert db_safe_priority(1) == 1
- assert db_safe_priority(-1) == -1
- assert db_safe_priority(9999999999) == DB_SAFE_MAXIMUM
- assert db_safe_priority(-9999999999) == DB_SAFE_MINIMUM
Review Comment:
Do we not need this anymore?
##########
task-sdk/tests/test_bases/test_operator.py:
##########
@@ -0,0 +1,34 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
Review Comment:
test_operator doesn't seem right, are there no modules for operator already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
