This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch v3-0-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/v3-0-test by this push:
new e2ecd8bccdb [v3-0-test] Fail upgrade pre-commit when pre-commits need
to be updated (#54346) (#54373)
e2ecd8bccdb is described below
commit e2ecd8bccdbe3afc54d67c200fa57460a6f499f6
Author: Jarek Potiuk <[email protected]>
AuthorDate: Tue Aug 12 00:55:58 2025 +0200
[v3-0-test] Fail upgrade pre-commit when pre-commits need to be updated
(#54346) (#54373)
(cherry picked from commit e1f4595f20ecdcca0a37a389577b495c32864afb)
---
.github/workflows/basic-tests.yml | 4 +++-
.pre-commit-config.yaml | 22 +++++++++-------------
contributing-docs/08_static_code_checks.rst | 2 --
dev/breeze/doc/images/output_static-checks.svg | 8 ++++----
dev/breeze/doc/images/output_static-checks.txt | 2 +-
dev/breeze/src/airflow_breeze/pre_commit_ids.py | 1 -
6 files changed, 17 insertions(+), 22 deletions(-)
diff --git a/.github/workflows/basic-tests.yml
b/.github/workflows/basic-tests.yml
index 8b12aa03b65..d6ea2b417e8 100644
--- a/.github/workflows/basic-tests.yml
+++ b/.github/workflows/basic-tests.yml
@@ -258,9 +258,11 @@ jobs:
python-version: ${{steps.breeze.outputs.host-python-version}}
skip-pre-commits: ${{ inputs.skip-pre-commits }}
- name: "Autoupdate all pre-commits"
- run: pre-commit autoupdate
+ run: pre-commit autoupdate --freeze
- name: "Autoupdate Lucas-C/pre-commit-hooks to bleeding edge"
run: pre-commit autoupdate --bleeding-edge --freeze --repo
https://github.com/Lucas-C/pre-commit-hooks
+ - name: "Check if there are any changes in pre-commit hooks"
+ run: git diff --exit-code
- name: "Run automated upgrade for black"
run: >
pre-commit run
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index bb2b851b079..026546d35c1 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -31,7 +31,7 @@ repos:
- id: check-hooks-apply
name: Check if all hooks apply to the repository
- repo: https://github.com/thlorenz/doctoc.git
- rev: v2.2.0
+ rev: 70fdcd39ef919754011a827bd25f23a0b141c3c3 # frozen: v2.2.0
hooks:
- id: doctoc
name: Add TOC for Markdown and RST files
@@ -50,7 +50,7 @@ repos:
- "2"
- repo: https://github.com/Lucas-C/pre-commit-hooks
# replace hash with version once PR #103 merged comes in a release
- rev: abdd8b62891099da34162217ecb3872d22184a51
+ rev: a30f0d816e5062a67d87c8de753cfe499672b959 # frozen: v1.5.5
hooks:
- id: insert-license
name: Add license for all SQL files
@@ -232,7 +232,7 @@ repos:
additional_dependencies: ['libcst>=1.1.0,!=1.8.0,!=1.8.1']
files: ^(providers/.*/)?airflow/.*/(sensors|operators)/.*\.py$
- repo: https://github.com/asottile/blacken-docs
- rev: 1.19.1
+ rev: 78a9dcbecf4f755f65d1f3dec556bc249d723600 # frozen: 1.19.1
hooks:
- id: blacken-docs
name: Run black on docs
@@ -245,7 +245,7 @@ repos:
alias: blacken-docs
additional_dependencies: ['black==24.10.0']
- repo: https://github.com/pre-commit/pre-commit-hooks
- rev: v5.0.0
+ rev: 3e8a8703264a2f4a69428a0aa4dcb512790b2c8c # frozen: v6.0.0
hooks:
- id: check-merge-conflict
name: Check that merge conflicts are not being committed
@@ -281,10 +281,6 @@ repos:
^airflow-core/docs/img/.*\.dot$|
^dev/breeze/doc/images/output.*$|
^.*/openapi-gen/.*$
- - id: fix-encoding-pragma
- name: Remove encoding header from Python files
- args:
- - --remove
- id: pretty-format-json
name: Format JSON files
args:
@@ -295,14 +291,14 @@ repos:
files: ^chart/values\.schema\.json$|^chart/values_schema\.schema\.json$
pass_filenames: true
- repo: https://github.com/pre-commit/pygrep-hooks
- rev: v1.10.0
+ rev: 3a6eb0fadf60b3cccfd80bad9dbb6fae7e47b316 # frozen: v1.10.0
hooks:
- id: rst-backticks
name: Check if RST files use double backticks for code
- id: python-no-log-warn
name: Check if there are no deprecate log warn
- repo: https://github.com/adrienverge/yamllint
- rev: v1.37.1
+ rev: 79a6b2b1392eaf49cdd32ac4f14be1a809bbd8f7 # frozen: v1.37.1
hooks:
- id: yamllint
name: Check YAML files with yamllint
@@ -320,7 +316,7 @@ repos:
^.*reproducible_build\.yaml$|
^.*pnpm-lock\.yaml$
- repo: https://github.com/ikamensh/flynt
- rev: '1.0.1'
+ rev: '97be693bf18bc2f050667dd282d243e2824b81e2' # frozen: 1.0.6
hooks:
- id: flynt
name: Run flynt string format converter for Python
@@ -331,7 +327,7 @@ repos:
- --line-length
- '99999'
- repo: https://github.com/codespell-project/codespell
- rev: v2.4.1
+ rev: 63c8f8312b7559622c0d82815639671ae42132ac # frozen: v2.4.1
hooks:
- id: codespell
name: Run codespell
@@ -357,7 +353,7 @@ repos:
-
--skip=providers/.*/src/airflow/providers/*/*.rst,providers/*/docs/changelog.rst,docs/*/commits.rst,providers/*/docs/commits.rst,providers/*/*/docs/commits.rst,docs/apache-airflow/tutorial/pipeline_example.csv,*.min.js,*.lock,INTHEWILD.md,*.svg
- --exclude-file=.codespellignorelines
- repo: https://github.com/woodruffw/zizmor-pre-commit
- rev: v1.11.0
+ rev: 69fa534d69454f44ddd4451b5e2da7a1c48e525b # frozen: v1.11.0
hooks:
- id: zizmor
name: Run zizmor to check for github workflow syntax errors
diff --git a/contributing-docs/08_static_code_checks.rst
b/contributing-docs/08_static_code_checks.rst
index b8144881544..9d7fed230c7 100644
--- a/contributing-docs/08_static_code_checks.rst
+++ b/contributing-docs/08_static_code_checks.rst
@@ -267,8 +267,6 @@ require Breeze Docker image to be built locally.
+-----------------------------------------------------------+--------------------------------------------------------+---------+
| end-of-file-fixer | Make sure that
there is an empty line at the end | |
+-----------------------------------------------------------+--------------------------------------------------------+---------+
-| fix-encoding-pragma | Remove encoding
header from Python files | |
-+-----------------------------------------------------------+--------------------------------------------------------+---------+
| flynt | Run flynt string
format converter for Python | |
+-----------------------------------------------------------+--------------------------------------------------------+---------+
| generate-airflow-diagrams | Generate airflow
diagrams | |
diff --git a/dev/breeze/doc/images/output_static-checks.svg
b/dev/breeze/doc/images/output_static-checks.svg
index 8ff92c29da3..bcfe7360743 100644
--- a/dev/breeze/doc/images/output_static-checks.svg
+++ b/dev/breeze/doc/images/output_static-checks.svg
@@ -359,10 +359,10 @@
</text><text class="breeze-static-checks-r5" x="0" y="947.2" textLength="12.2"
clip-path="url(#breeze-static-checks-line-38)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="947.2" textLength="988.2"
clip-path="url(#breeze-static-checks-line-38)">check-urlparse-usage-in-code | check-xml | check-zip-file-is-not-committed |     </text><text
class="breeze-static-checks-r5" x="1451.8" y="947.2" textLength="12.2"
clip-path="url(#bre [...]
</text><text class="breeze-static-checks-r5" x="0" y="971.6" textLength="12.2"
clip-path="url(#breeze-static-checks-line-39)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="971.6" textLength="988.2"
clip-path="url(#breeze-static-checks-line-39)">codespell | compile-fab-assets | compile-ui-assets | compile-ui-assets-dev |     </text><text
class="breeze-static-checks-r5" x="1451.8" y="971.6" textLength="12.2"
clip-path [...]
</text><text class="breeze-static-checks-r5" x="0" y="996" textLength="12.2"
clip-path="url(#breeze-static-checks-line-40)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="996" textLength="988.2"
clip-path="url(#breeze-static-checks-line-40)">create-missing-init-py-files-tests | debug-statements | detect-private-key |     </text><text
class="breeze-static-checks-r5" x="1451.8" y="996" textLength="12.2"
clip-path="url(#breeze-st [...]
-</text><text class="breeze-static-checks-r5" x="0" y="1020.4"
textLength="12.2" clip-path="url(#breeze-static-checks-line-41)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="1020.4" textLength="988.2"
clip-path="url(#breeze-static-checks-line-41)">doctoc | end-of-file-fixer | fix-encoding-pragma | flynt |                       <
[...]
-</text><text class="breeze-static-checks-r5" x="0" y="1044.8"
textLength="12.2" clip-path="url(#breeze-static-checks-line-42)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="1044.8" textLength="988.2"
clip-path="url(#breeze-static-checks-line-42)">generate-airflow-diagrams | generate-openapi-spec | generate-openapi-spec-fab |  </text><text
class="breeze-static-checks-r5" x="1451.8" y="1044.8" textLength="12.2"
clip-path="url(#breeze-static-c [...]
-</text><text class="breeze-static-checks-r5" x="0" y="1069.2"
textLength="12.2" clip-path="url(#breeze-static-checks-line-43)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="1069.2" textLength="988.2"
clip-path="url(#breeze-static-checks-line-43)">generate-pypi-readme | generate-tasksdk-datamodels | generate-volumes-for-sources</text><text
class="breeze-static-checks-r5" x="1451.8" y="1069.2" textLength="12.2"
clip-path="url(#breeze-static-checks-line-43)" [...]
-</text><text class="breeze-static-checks-r5" x="0" y="1093.6"
textLength="12.2" clip-path="url(#breeze-static-checks-line-44)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="1093.6" textLength="988.2"
clip-path="url(#breeze-static-checks-line-44)">| identity | insert-license | kubeconform | lint-chart-schema | lint-dockerfile |</text><text
class="breeze-static-checks-r5" x="1451.8" y="1093.6" textLength="12.2"
clip-path="url(# [...]
+</text><text class="breeze-static-checks-r5" x="0" y="1020.4"
textLength="12.2" clip-path="url(#breeze-static-checks-line-41)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="1020.4" textLength="988.2"
clip-path="url(#breeze-static-checks-line-41)">doctoc | end-of-file-fixer | flynt | generate-airflow-diagrams |                 </text><text
class="breeze-stat [...]
+</text><text class="breeze-static-checks-r5" x="0" y="1044.8"
textLength="12.2" clip-path="url(#breeze-static-checks-line-42)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="1044.8" textLength="988.2"
clip-path="url(#breeze-static-checks-line-42)">generate-openapi-spec | generate-openapi-spec-fab | generate-pypi-readme |       </text><text
class="breeze-static-checks-r5" x="1451.8" y="1044.8" textLength="12.2" clip-p
[...]
+</text><text class="breeze-static-checks-r5" x="0" y="1069.2"
textLength="12.2" clip-path="url(#breeze-static-checks-line-43)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="1069.2" textLength="988.2"
clip-path="url(#breeze-static-checks-line-43)">generate-tasksdk-datamodels | generate-volumes-for-sources | identity |          </text><text
class="breeze-static-checks-r5" x="1451.8" y="1069.2" textLengt [...]
+</text><text class="breeze-static-checks-r5" x="0" y="1093.6"
textLength="12.2" clip-path="url(#breeze-static-checks-line-44)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="1093.6" textLength="988.2"
clip-path="url(#breeze-static-checks-line-44)">insert-license | kubeconform | lint-chart-schema | lint-dockerfile |             </text><text
class="breeze-static-checks-r5" x="145 [...]
</text><text class="breeze-static-checks-r5" x="0" y="1118" textLength="12.2"
clip-path="url(#breeze-static-checks-line-45)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="1118" textLength="988.2"
clip-path="url(#breeze-static-checks-line-45)">lint-helm-chart | lint-json-schema | lint-markdown | mixed-line-ending |         </text><text
class="breeze-static-checks-r5" x="1451.8" y="1118" textLength [...]
</text><text class="breeze-static-checks-r5" x="0" y="1142.4"
textLength="12.2" clip-path="url(#breeze-static-checks-line-46)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="1142.4" textLength="988.2"
clip-path="url(#breeze-static-checks-line-46)">mypy-airflow-core | mypy-airflow-ctl | mypy-dev | mypy-devel-common |            </text><text
class="breeze-static-checks-r5" x="1451.8" [...]
</text><text class="breeze-static-checks-r5" x="0" y="1166.8"
textLength="12.2" clip-path="url(#breeze-static-checks-line-47)">│</text><text
class="breeze-static-checks-r7" x="451.4" y="1166.8" textLength="988.2"
clip-path="url(#breeze-static-checks-line-47)">mypy-providers | mypy-task-sdk | pretty-format-json | pylint | python-no-log-warn</text><text
class="breeze-static-checks-r5" x="1451.8" y="1166.8" textLength="12.2"
clip-path="url(#breeze-sta [...]
diff --git a/dev/breeze/doc/images/output_static-checks.txt
b/dev/breeze/doc/images/output_static-checks.txt
index 5d493551b20..32222494f6f 100644
--- a/dev/breeze/doc/images/output_static-checks.txt
+++ b/dev/breeze/doc/images/output_static-checks.txt
@@ -1 +1 @@
-3d43a8428b5e0fefbfccaef5003fa5a6
+e4e9ca98d368d38237503800292febf1
diff --git a/dev/breeze/src/airflow_breeze/pre_commit_ids.py
b/dev/breeze/src/airflow_breeze/pre_commit_ids.py
index 7095d55b43f..c7ce5bccaa2 100644
--- a/dev/breeze/src/airflow_breeze/pre_commit_ids.py
+++ b/dev/breeze/src/airflow_breeze/pre_commit_ids.py
@@ -97,7 +97,6 @@ PRE_COMMIT_LIST = [
"detect-private-key",
"doctoc",
"end-of-file-fixer",
- "fix-encoding-pragma",
"flynt",
"generate-airflow-diagrams",
"generate-openapi-spec",
