guan404ming commented on code in PR #54221:
URL: https://github.com/apache/airflow/pull/54221#discussion_r2268590969
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/hive_to_dynamodb.py:
##########
@@ -104,7 +107,10 @@ def execute(self, context: Context):
self.log.info("Inserting rows into dynamodb")
if self.pre_process is None:
-
dynamodb.write_batch_data(json.loads(data.to_json(orient="records")))
+ if self.df_type == "polars":
Review Comment:
I still think it’s not necessary since the current implementation already
makes it clear whether it’s using polars or pandas in most cases. I’d be happy
to hear what others think. If the community feels it would be useful, I’m more
than willing to add it.
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/hive_to_dynamodb.py:
##########
@@ -104,7 +107,10 @@ def execute(self, context: Context):
self.log.info("Inserting rows into dynamodb")
if self.pre_process is None:
-
dynamodb.write_batch_data(json.loads(data.to_json(orient="records")))
+ if self.df_type == "polars":
Review Comment:
I still think it’s not necessary since the current implementation already
makes it clear whether it’s using polars or pandas in most cases. I’d be happy
to hear what others think. If the community feels it would be useful, I’m
willing to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
