bugraoz93 commented on code in PR #54382:
URL: https://github.com/apache/airflow/pull/54382#discussion_r2269254651
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dags.py:
##########
@@ -89,6 +90,7 @@ def get_dags(
last_dag_run_state: QueryLastDagRunStateFilter,
bundle_name: QueryBundleNameFilter,
bundle_version: QueryBundleVersionFilter,
+ is_scheduled:QueryIsDagScheduledFilter,
Review Comment:
```suggestion
is_scheduled: QueryIsDagScheduledFilter,
```
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -540,6 +540,22 @@ def is_active(self) -> bool:
self.value.lower_bound is not None or self.value.upper_bound is
not None
)
+class _IsDagScheduledFilter(BaseParam[bool]):
+ """Filter on timetable_description."""
+
+ def to_orm(self, select: Select) -> Select:
+ if not self.value is None and self.skip_none:
+ if not self.value:
Review Comment:
You have already added `if not self.value is None` above which makes this
`if not self.value` always true. We may either need two if separately if they
are separate cases or merge them into one could be make sense too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
