kirubankamaraj commented on code in PR #54302:
URL: https://github.com/apache/airflow/pull/54302#discussion_r2270532768
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -526,8 +528,14 @@ def to_orm(self, select: Select) -> Select:
if self.value and self.value.lower_bound:
select = select.where(self.attribute >= self.value.lower_bound)
+ if self.value and self.value.lower_bound_excluded:
+ select = select.where(self.attribute >
self.value.lower_bound_excluded)
+
Review Comment:
@pierrejeambrun I feel the same while writing this but then thinking the
case if the user pass upper_bound_lte and upper_bound_lt we can't only took any
one because it's depend on the query value, if upper_bound_lte is 10 and
upper_bound_lt is 5 then the data needs to be less than five and the same for
vice versa case.
If you feel current statement is making query complex then I can find the
min value and use that with the respect condition, and max value for lower
bound. is that okay for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
