guan404ming commented on code in PR #54435:
URL: https://github.com/apache/airflow/pull/54435#discussion_r2275683913
##########
airflow-core/src/airflow/ui/src/pages/DagsList/DagsList.tsx:
##########
@@ -246,7 +241,7 @@ export const DagsList = () => {
}
const { data, error, isLoading } = useDags({
- dagDisplayNamePattern: Boolean(dagDisplayNamePattern) ?
dagDisplayNamePattern : undefined,
+ dagDisplayNamePattern: Boolean(dagDisplayNamePattern) ?
`${dagDisplayNamePattern}` : undefined,
Review Comment:
Since `Boolean("") = false`, we could set `const dagDisplayNamePattern =
searchParams.get(NAME_PATTERN) ?? "";` and not affect the function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
