[
https://issues.apache.org/jira/browse/AIRFLOW-5886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971232#comment-16971232
]
ASF GitHub Bot commented on AIRFLOW-5886:
-----------------------------------------
potiuk commented on pull request #6538: [AIRFLOW-5886] Selective copying of
sources in Docker image depends on [AIRFLOW-5885]
URL: https://github.com/apache/airflow/pull/6538
Note for reviewed - this change depends on #6536 so please review only last
commit.
This change further improves time of rebuilds for docker image when your
sources change (very useful in case of building kubernetes image). It adds
only
directories that are needed (it is synchronised with .dockerignore and local
mounts) and in the sequence that reflects frequency of changes. Also pip
install is not done again after sources change (there is no point) so the
build is much faster when only sources or test file change.
Also - since we are modifying Dockerfile, it turned out that "airflow" user
is not needed
in the CI image any more so I removed it to save additional Dockerfile
modification.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Copying sources in Dockerfile can be selective
> ----------------------------------------------
>
> Key: AIRFLOW-5886
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5886
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: ci
> Affects Versions: 2.0.0, 1.10.6
> Reporter: Jarek Potiuk
> Priority: Major
>
> This change will further improve time of rebuilds for docker image when your
> sources change (very useful in case of building kubernetes image). It adds
> only directories that are needed (it is synchronised with .dockerignore and
> local mounts) and in the sequence that reflects frequency of changes. Also
> pip install is not done again after sources change (there is no point) so the
> build is much faster when only sources or test file change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
