This is an automated email from the ASF dual-hosted git repository.

ferruzzi pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new 575a3b5eddc Quick change to make ruff and mypy happy (#54529)
575a3b5eddc is described below

commit 575a3b5eddc2a80e68027c98fcf6c35348363047
Author: D. Ferruzzi <[email protected]>
AuthorDate: Fri Aug 15 15:16:28 2025 -0700

    Quick change to make ruff and mypy happy (#54529)
---
 .../src/airflow/providers/oracle/hooks/oracle.py   | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/providers/oracle/src/airflow/providers/oracle/hooks/oracle.py 
b/providers/oracle/src/airflow/providers/oracle/hooks/oracle.py
index 698572486ef..2a7cdc5f0e3 100644
--- a/providers/oracle/src/airflow/providers/oracle/hooks/oracle.py
+++ b/providers/oracle/src/airflow/providers/oracle/hooks/oracle.py
@@ -358,21 +358,19 @@ class OracleHook(DbApiHook):
             )
 
         if sequence_column and sequence_name:
-            prepared_stm = "insert into {tablename} {columns} values 
({values})".format(
-                tablename=table,
-                columns="({})".format(", ".join([sequence_column] + 
target_fields))
+            columns = (
+                f"({', '.join([sequence_column] + target_fields)})"
                 if target_fields
-                else f"({sequence_column})",
-                values=", ".join(
-                    [f"{sequence_name}.NEXTVAL"] + [f":{i}" for i in range(1, 
len(values_base) + 1)]
-                ),
+                else f"({sequence_column})"
             )
-        else:
-            prepared_stm = "insert into {tablename} {columns} values 
({values})".format(
-                tablename=table,
-                columns="({})".format(", ".join(target_fields)) if 
target_fields else "",
-                values=", ".join(f":{i}" for i in range(1, len(values_base) + 
1)),
+            value_placeholders = ", ".join(
+                [f"{sequence_name}.NEXTVAL"] + [f":{i}" for i in range(1, 
len(values_base) + 1)]
             )
+        else:
+            columns = f"({', '.join(target_fields)})" if target_fields else ""
+            value_placeholders = ", ".join(f":{i}" for i in range(1, 
len(values_base) + 1))
+        prepared_stm = f"insert into {table} {columns} values 
({value_placeholders})"
+
         row_count = 0
         # Chunk the rows
         row_chunk = []

Reply via email to