Programmer-RD-AI commented on code in PR #54582:
URL: https://github.com/apache/airflow/pull/54582#discussion_r2280743655
##########
providers/amazon/src/airflow/providers/amazon/aws/utils/eks_get_token.py:
##########
@@ -51,9 +53,16 @@ def get_parser():
return parser
+def _ensure_db_session():
+ if not getattr(settings, "engine", None) or not getattr(settings,
"Session", None):
+ configure_orm()
Review Comment:
a few small suggestions: maybe we could rename `_ensure_db_session` to
`_ensure_orm_configured`? i think it is more fitting for what the function is
specifically doing, as well as a small doc string with what is specifically
happening within this function would be nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
