amoghrajesh commented on code in PR #53387:
URL: https://github.com/apache/airflow/pull/53387#discussion_r2282508787
##########
task-sdk/tests/task_sdk/definitions/test_secrets_masker.py:
##########
@@ -357,7 +357,6 @@ def __init__(self, required_arg):
[
(DagRunState.SUCCESS, "success"),
(TaskInstanceState.FAILED, "failed"),
- (JobState.RUNNING, "running"),
Review Comment:
Yeah its fine to remove, couple of examples in the params anyways
##########
airflow-core/src/airflow/utils/state.py:
##########
@@ -20,18 +20,6 @@
from enum import Enum
-class JobState(str, Enum):
- """All possible states that a Job can be in."""
-
- RUNNING = "running"
- SUCCESS = "success"
- RESTARTING = "restarting"
- FAILED = "failed"
-
- def __str__(self) -> str:
- return self.value
Review Comment:
Needs a compat shim in `utils/__init__.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
