ferruzzi commented on code in PR #53831: URL: https://github.com/apache/airflow/pull/53831#discussion_r2283436792
########## task-sdk/src/airflow/sdk/bases/notifier.py: ########## @@ -33,11 +32,31 @@ class BaseNotifier(LoggingMixin, Templater): - """BaseNotifier class for sending notifications.""" + """ + BaseNotifier class for sending notifications. + + It can be used asynchronously (preferred) if `async_notify`is implemented and/or + synchronously if `notify` is implemented. + + Currently, the DAG/Task state change callbacks run on the DAG Processor and only support sync usage. + + Usage: Review Comment: I didn't realize that would work. Neat. I'll make the change and et back to you on the rest ASAP. Thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
