potiuk commented on issue #50737: URL: https://github.com/apache/airflow/issues/50737#issuecomment-3198771546
> In [airflow/providers/discord/notifications/discord.py], we're currently using a raw GitHub URL for the `ICON_URL`: > > ICON_URL: str = ( > "https://raw.githubusercontent.com/apache/airflow/main/airflow-core/src/airflow/ui/public/pin_100.png"; > ) > I feel the current implementation is correct and doesn't need to be changed to use the GitHub API. The GitHub API would only add unnecessary complexity and potential rate limiting issues for this use case. > > If there's a specific reason to use the GitHub API that I'm missing, please let me know! Yes. It can be left like it is. @amoghrajesh -> I suggest to close the issue. We have not seen the rate limit to hit our CI any more and I would say we should only fix those cases that **really** matter - otherwise it adds complexity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://raw.githubusercontent.com/apache/airflow/main/airflow-core/src/airflow/ui/public/pin_100.png"](https://raw.githubusercontent.com/apache/airflow/main/airflow-core/src/airflow/ui/public/pin_100.png"){kind=link}