dabla commented on PR #54598: URL: https://github.com/apache/airflow/pull/54598#issuecomment-3199579464
> > If they directly interact with get_conn then yes it's would be broken, but that would be a bad practise normally you should use the run method. I can add a new get_async_conn method and keep the original for backward compatibility. > > I'm not into the details of this change. If this works on AF2 and we have reasonable claim to classify it as bug fix then this is fine. If mitigation steps or special instructions into what was changed are needed then we need a log entry to specify this change (a key indication to know if this is required is: if we expect that as a result of releasing this change workflows will behave differently) Well I just kept original method and added new async one like other providers do, it wasn't big of a deal after all, and so we are certain we don't break anything, @gopidesupavan was right by mentioning this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
