pierrejeambrun commented on code in PR #54218:
URL: https://github.com/apache/airflow/pull/54218#discussion_r2285884288
##########
airflow-core/src/airflow/utils/helpers.py:
##########
@@ -204,7 +204,7 @@ def build_airflow_dagrun_url(dag_id: str, run_id: str) ->
str:
http://localhost:8080/dags/hi/runs/manual__2025-02-23T18:27:39.051358+00:00_RZa1at4Q
"""
baseurl = conf.get("api", "base_url", fallback="/")
- return urljoin(baseurl, f"dags/{dag_id}/runs/{run_id}")
+ return urljoin(f"{baseurl.rstrip('/')}" + "/",
f"dags/{dag_id}/runs/{run_id}")
Review Comment:
f string seems useless.
```suggestion
return urljoin(baseurl.rstrip('/') + "/", f"dags/{dag_id}/runs/{run_id}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
