kaxil commented on code in PR #54569:
URL: https://github.com/apache/airflow/pull/54569#discussion_r2287697589
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -1426,7 +1496,7 @@ def _serialize_node(cls, op: SdkOperator |
SchedulerOperator) -> dict[str, Any]:
# Store all template_fields as they are if there are JSON Serializable
# If not, store them as strings
# And raise an exception if the field is not templateable
- forbidden_fields =
set(SerializedBaseOperator._CONSTRUCTOR_PARAMS.keys())
+ forbidden_fields =
set(signature(BaseOperator.__init__).parameters.keys())
Review Comment:
This might not catch parent class fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
