pierrejeambrun commented on code in PR #54382:
URL: https://github.com/apache/airflow/pull/54382#discussion_r2288056266
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -540,6 +540,22 @@ def is_active(self) -> bool:
self.value.lower_bound is not None or self.value.upper_bound is
not None
)
+class _IsDagScheduledFilter(BaseParam[bool]):
+ """Filter on timetable_description."""
+
+ def to_orm(self, select: Select) -> Select:
+ if not self.value is None and self.skip_none:
+ if not self.value:
Review Comment:
I had the exact first idea. Maybe we should refactor it so it's less
confusing. We don't want to bother handling the `None` expliciit filtering for
now. Pseudo code not tested:
```python
if self.skip_none is False:
raise ValueError(f"Cannot set 'skip_none' to False on a
{type(self)}")
if self.value is None:
return select
if self.value:
return
select.where(DagModel.timetable_description.ilike("Never%"))|
else:
return
select.where(DagModel.timetable_description.not_like("Never%"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
