HsiuChuanHsu commented on code in PR #54115:
URL: https://github.com/apache/airflow/pull/54115#discussion_r2289506662
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py:
##########
@@ -254,28 +275,51 @@ def process_status(
and
container_status_state["waiting"]["message"] == "pull QPS exceeded"
):
continue
- self.log.error(
- "Event: %s has container %s with fatal reason
%s",
+ key = annotations_to_key(annotations=annotations)
+ task_key_str = (
+ f"{key.dag_id}.{key.task_id}.{key.try_number}"
if key else "unknown"
+ )
+ self.log.warning(
+ "Event: %s has container %s with fatal reason
%s, task: %s",
pod_name,
container_status["name"],
container_status_state["waiting"]["reason"],
+ task_key_str,
)
self.watcher_queue.put(
- (pod_name, namespace,
TaskInstanceState.FAILED, annotations, resource_version)
+ (
+ pod_name,
+ namespace,
+ TaskInstanceState.FAILED,
+ annotations,
+ resource_version,
+ failure_details,
+ )
)
break
else:
self.log.info("Event: %s Pending, annotations: %s",
pod_name, annotations_string)
else:
self.log.debug("Event: %s Pending, annotations: %s", pod_name,
annotations_string)
elif status == "Failed":
- self.log.error("Event: %s Failed, annotations: %s", pod_name,
annotations_string)
+ key = annotations_to_key(annotations=annotations)
+ task_key_str = f"{key.dag_id}.{key.task_id}.{key.try_number}" if
key else "unknown"
+ self.log.warning(
+ "Event: %s Failed, task: %s, annotations: %s", pod_name,
task_key_str, annotations_string
+ )
Review Comment:
Fixed this part! True, just keep the failure_details from `status ==
"Failed"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
