kaxil commented on code in PR #54449:
URL: https://github.com/apache/airflow/pull/54449#discussion_r2292286328
##########
devel-common/src/tests_common/pytest_plugin.py:
##########
@@ -1808,24 +1808,69 @@ def _disable_redact(request: pytest.FixtureRequest,
mocker):
yield
return
- from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS
+ from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS,
AIRFLOW_V_3_1_PLUS
if next(request.node.iter_markers("enable_redact"), None):
with pytest.MonkeyPatch.context() as mp_ctx:
- mp_ctx.setattr(settings, "MASK_SECRETS_IN_LOGS", True)
+ if AIRFLOW_V_3_1_PLUS:
Review Comment:
Why do we have if/else and try..catch both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
