guan404ming commented on PR #54783:
URL: https://github.com/apache/airflow/pull/54783#issuecomment-3213064908
> Not sure whether it's ideal in this case as we have both options and
params here. If we do things this way, it will be confusing when users want
something like params_input={"options": ...} (it probably doesn't make as much
sense but should be valid)
I also have the concern about that case. Since we already preserve the
`options`, it would cause conflict like @Lee-W said if we use `?key=value`
here.
IMO The preload behavior in this PR is scoped only to `HitlResponseForm` and
won’t affect other forms. In this sense, `options` and `params` could remain
preserved specifically for hitl without impacting other pages (once we
implement additional preload behaviors later). Other pages could still use
`http://.../required_actions?key=value` to preload data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
