RoyLee1224 opened a new pull request, #54895:
URL: https://github.com/apache/airflow/pull/54895
## Why
As mentioned in #54049 , the filters take up too much screen space. To
address this, this PR introduces a new, reusable "filter pill" component design
for `date`, `number`, `text` input.
I would appreciate any early feedback on the overall design and direction.
All comments and suggestions are welcome.
## What
- **Add & Edit**: Click `+ Filter` to select a filter type from the dropdown
menu. A new filter pill appears and is automatically focused. You can also
click on any existing pill to edit its value.
- **Confirm & Cancel**: Once you're done typing, you can:
- Press `Enter` to confirm the value and apply the filter.
- Press `Esc` or click anywhere outside the input area to cancel and
exit editing mode.
- **Delete**:
- Click the `x` icon on any pill to remove that specific filter.
- Click `Reset` button to clear all active filters at once.
## Screenshots
https://github.com/user-attachments/assets/80b52b93-769e-4137-9248-2ab7048be4da
## TO-DO
Working on resolving an issue with the `NumberFilter` where inputting a
minus sign (-) causes UI bug. This PR will remain in a draft state until this
is fixed.
##
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
