jason810496 commented on code in PR #54813:
URL: https://github.com/apache/airflow/pull/54813#discussion_r2304157218
##########
providers/alibaba/src/airflow/providers/alibaba/cloud/log/oss_task_handler.py:
##########
@@ -95,6 +95,9 @@ def read(self, relative_path, ti: RuntimeTI) ->
tuple[LogSourceInfo, LogMessages
return messages, logs
return messages, None
+ def stream(self, relative_path: str, ti: RuntimeTI) -> LogResponse:
+ raise NotImplementedError
Review Comment:
> Hmmm, it's a bit annoying that we need to define this in all the
subclasses (as otherwise it fails the protocol check).
So do I
> I wonder if there's a different option we could take here 🤔
I had though about another approach by replacing the `RemoteLogIO` Protocal
with ABC, then the `stream` method will raise `NotImplementedError` by default.
No sure if there is any concern of using ABC instead of Protocal ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
