bbovenzi commented on code in PR #54640:
URL: https://github.com/apache/airflow/pull/54640#discussion_r2305987664
##########
airflow-core/src/airflow/ui/src/components/Assets/AssetEvents.tsx:
##########
@@ -64,6 +69,64 @@ export const AssetEvents = ({
{ label: translate("sortBy.oldestFirst"), value: "timestamp" },
],
});
+ const runTypes = ["", "asset_triggered", "backfill", "manual", "scheduled"];
+ const runTypeOptions = createListCollection({
+ items: runTypes.map((type) => ({
+ label: type === "" ? "\u00A0" : translate(`common:runTypes.${type}`),
Review Comment:
I think in other areas we just used the text "all" for value and matched on
that. I think it would be nice to stay consistent even if the functionality is
the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
