This is an automated email from the ASF dual-hosted git repository.

uranusjr pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new bf4e4a923b8 Use 'orient' kwarg in SalesforceHook (#55056)
bf4e4a923b8 is described below

commit bf4e4a923b818592a87f30139476fd0b07141743
Author: Tzu-ping Chung <[email protected]>
AuthorDate: Fri Aug 29 16:13:06 2025 +0800

    Use 'orient' kwarg in SalesforceHook (#55056)
---
 .../salesforce/src/airflow/providers/salesforce/hooks/salesforce.py | 4 ++--
 providers/salesforce/tests/unit/salesforce/hooks/test_salesforce.py | 6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git 
a/providers/salesforce/src/airflow/providers/salesforce/hooks/salesforce.py 
b/providers/salesforce/src/airflow/providers/salesforce/hooks/salesforce.py
index 14a8e64113f..9368cd40c5b 100644
--- a/providers/salesforce/src/airflow/providers/salesforce/hooks/salesforce.py
+++ b/providers/salesforce/src/airflow/providers/salesforce/hooks/salesforce.py
@@ -343,9 +343,9 @@ class SalesforceHook(BaseHook):
             # write the dataframe
             df.to_csv(filename, index=False)
         elif fmt == "json":
-            df.to_json(filename, "records", date_unit="s")
+            df.to_json(filename, orient="records", date_unit="s")
         elif fmt == "ndjson":
-            df.to_json(filename, "records", lines=True, date_unit="s")
+            df.to_json(filename, orient="records", lines=True, date_unit="s")
 
         return df
 
diff --git 
a/providers/salesforce/tests/unit/salesforce/hooks/test_salesforce.py 
b/providers/salesforce/tests/unit/salesforce/hooks/test_salesforce.py
index ea96aa02bb1..9cb33157aee 100644
--- a/providers/salesforce/tests/unit/salesforce/hooks/test_salesforce.py
+++ b/providers/salesforce/tests/unit/salesforce/hooks/test_salesforce.py
@@ -377,7 +377,9 @@ class TestSalesforceHook:
         )
 
         mock_describe_object.assert_called_once_with(obj_name)
-        mock_data_frame.return_value.to_json.assert_called_once_with(filename, 
"records", date_unit="s")
+        mock_data_frame.return_value.to_json.assert_called_once_with(
+            filename, orient="records", date_unit="s"
+        )
         pd.testing.assert_frame_equal(
             data_frame, pd.DataFrame({"test": [1, 2, 3], "field_1": 
[1.546301e09, 1.546387e09, 1.546474e09]})
         )
@@ -396,7 +398,7 @@ class TestSalesforceHook:
         )
 
         mock_data_frame.return_value.to_json.assert_called_once_with(
-            filename, "records", lines=True, date_unit="s"
+            filename, orient="records", lines=True, date_unit="s"
         )
         pd.testing.assert_frame_equal(
             data_frame,

Reply via email to