jscheffl commented on code in PR #55041:
URL: https://github.com/apache/airflow/pull/55041#discussion_r2311481145
##########
airflow-core/src/airflow/ui/public/i18n/locales/en/hitl.json:
##########
@@ -6,6 +6,7 @@
"received": "Reviewed"
}
},
+ "needsReview": "Needs Review",
Review Comment:
I understand that many use cases are probably "Review" kind of but the
purpose of HITL is not only Approval, but also some "Decsion" or "Input
Request".
As we anmed all previously "Action Required" or "Repsonse" which is neutral
I'd favor not changing the terms here but keeping it neutral as "Needs Action".
Also in the "Browse..." Menu we have it as "Required Actions"
```suggestion
"<to be renamed>": "Requires Action",
```
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -647,22 +647,22 @@ def to_orm(self, select: Select) -> Select:
asset_ref_subquery =
sql_select(DagScheduleAssetReference.dag_id).distinct()
if self.value:
- # Filter DAGs that have asset-based scheduling
+ # Filter Dags that have asset-based scheduling
return select.where(DagModel.dag_id.in_(asset_ref_subquery))
- # Filter DAGs that do NOT have asset-based scheduling
+ # Filter Dags that do NOT have asset-based scheduling
Review Comment:
Oh, how was this over-looked before? Are there more of these in the codebase?
##########
airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/StateFilters.tsx:
##########
@@ -65,6 +74,17 @@ export const StateFilters = ({ isAll, isFailed, isRunning,
isSuccess, onStateCha
<StateBadge state="success" />
{translate("common:states.success")}
</QuickFilterButton>
+ <QuickFilterButton
+ data-testid="dags-needs-review-filter"
+ isActive={needsReview}
+ onClick={onStateChange}
+ value="needs_review"
+ >
+ <StateBadge colorPalette="deferred">
+ <LuUserRoundPen />
+ </StateBadge>
+ {translate("hitl:needsReview")}
Review Comment:
Interesting, code looks good but on my instance the I18n label is not found,
even after I was hitting F5 multiple times...
<img width="553" height="186" alt="Image"
src="https://github.com/user-attachments/assets/e04af0cc-a71e-4f0f-8665-c057d45888b0";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
