kaxil commented on code in PR #54943:
URL: https://github.com/apache/airflow/pull/54943#discussion_r2311727564
##########
task-sdk/src/airflow/sdk/definitions/dag.py:
##########
@@ -1096,10 +1096,10 @@ def test(
from contextlib import ExitStack
from airflow import settings
- from airflow.configuration import secrets_backend_list
from airflow.models.dag import DAG as SchedulerDAG,
_get_or_create_dagrun
from airflow.models.dagrun import DagRun
from airflow.sdk import timezone
+ from airflow.sdk._shared.configuration import secrets_backend_list
Review Comment:
In some place we use:
```py
from airflow.sdk.configuration import conf
```
and here:
```
from airflow.sdk._shared.configuration import secrets_backend_list
```
We should use one or the other imo consistently.
`airflow.sdk._shared.configuration` vs `from airflow.sdk.configuration`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
