HsiuChuanHsu opened a new pull request, #55107:
URL: https://github.com/apache/airflow/pull/55107
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
## Description
The Kubernetes API server's response body is not always guaranteed to be
JSON. For example, in the case of a 429 (Too Many Requests) response, the body
may be a plain string rather than JSON, causing json.loads() to fail with a
JSONDecodeError.
https://github.com/kubernetes-client/python/blob/6e7c539f52dec4e993d2c32a4408920d8522f47e/kubernetes/base/dynamic/exceptions.py#L45C1-L77C1
This issue manifests in two key areas:
- **KubernetesExecutor**: When handling `ApiException` during task
publishing
- **KubernetesInstallKueueOperator**: When processing `FailToCreateError`
exceptions
## Change Mades:
1. KubernetesExecutor (`kubernetes_executor.py`):
- Added try/catch block around json.loads(e.body)
- Handle empty body cases by using e.reason as fallback
- Handle non-JSON bodies (like 429 plain text responses) by wrapping in
message structure
2. KubernetesInstallKueueOperator (`kueue.py`):
- Enhanced error body parsing with JSON fallback handling
- Handle empty bodies using exception reason
Closes
Fixes #49244
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
