vincbeck commented on code in PR #54926: URL: https://github.com/apache/airflow/pull/54926#discussion_r2316539049
########## airflow-core/src/airflow/security/permissions.py: ########## @@ -41,7 +41,6 @@ RESOURCE_DAG_DEPENDENCIES = "DAG Dependencies" RESOURCE_DAG_PREFIX = "DAG:" RESOURCE_DAG_RUN = "DAG Runs" -RESOURCE_DAG_RUN_PREFIX = "DAG Run:" Review Comment: I updated the code to keep using the prefix "DAG Run:" to check dag run permissions. Even though I have having this code in the codebase, I think we must keep it for now ########## airflow-core/src/airflow/security/permissions.py: ########## @@ -41,7 +41,6 @@ RESOURCE_DAG_DEPENDENCIES = "DAG Dependencies" RESOURCE_DAG_PREFIX = "DAG:" RESOURCE_DAG_RUN = "DAG Runs" -RESOURCE_DAG_RUN_PREFIX = "DAG Run:" Review Comment: I updated the code to keep using the prefix "DAG Run:" to check dag run permissions. Even though I hate having this code in the codebase, I think we must keep it for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
