pierrejeambrun commented on code in PR #53563:
URL: https://github.com/apache/airflow/pull/53563#discussion_r2316535172
##########
providers/edge3/src/airflow/providers/edge3/plugins/www/dist/main.d.ts:
##########
Review Comment:
I don't think we want to push the `dist` build similarly to other UIs. (That
should be gitignore, build in time when running breeze or building the provider
package I guess)
##########
providers/edge3/src/airflow/providers/edge3/plugins/www/package.json:
##########
@@ -0,0 +1,80 @@
+{
+ "name": "edge",
+ "private": true,
+ "version": "0.0.0",
+ "type": "module",
+ "main": "./dist/main.js",
+ "module": "./dist/main.js",
+ "types": "./dist/main.d.ts",
+ "exports": {
+ ".": {
+ "import": "./dist/main.js",
+ "types": "./dist/main.d.ts"
+ }
+ },
+ "files": [
+ "dist"
+ ],
+ "scripts": {
+ "dev": "vite --port 5173 --strictPort",
+ "build": "vite build",
+ "build:types": "tsc --p tsconfig.lib.json",
+ "build:lib": "vite build",
+ "lint": "eslint --quiet && tsc --p tsconfig.app.json",
+ "lint:fix": "eslint --fix && tsc --p tsconfig.app.json",
+ "format": "pnpm prettier --write .",
+ "preview": "vite preview",
+ "codegen": "openapi-rq -i ../../openapi/v2-edge-generated.yaml -c axios
--format prettier -o openapi-gen --operationId",
Review Comment:
It's done as part of the precommit hook. `ts-compile-lint-ui`. This way the
generated code and source spec file are always in sync.
##########
providers/edge3/docs/ui_plugin.rst:
##########
@@ -30,13 +30,13 @@ REST API endpoints
The Edge provider adds the following REST API endpoints to the Airflow API:
-- ``/api/v1/edge/health``: Check that the API endpoint is deployed and active
-- ``/api/v1/edge/jobs``: Endpoints to fetch jobs for workers and report state
-- ``/api/v1/edge/logs``: Endpoint to push log chunks from workers to the
Airflow cluster
-- ``/api/v1/edge/workers``: Endpoints to register and manage workers, report
heartbeat
+- ``/edge_worker/v1/jobs``: Endpoints to fetch jobs for workers and report
state
+- ``/edge_worker/v1/logs``: Endpoint to push log chunks from workers to the
Airflow cluster
+- ``/edge_worker/v1/workers``: Endpoints to register and manage workers,
report heartbeat
+- ``/edge_worker/v1/health``: Check that the API endpoint is deployed and
active
Review Comment:
Is that a problem from backward compatibility point of view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
