ashb commented on code in PR #55135:
URL: https://github.com/apache/airflow/pull/55135#discussion_r2313918532
##########
task-sdk/tests/task_sdk/definitions/test_dag.py:
##########
@@ -72,6 +72,9 @@ def test_dag_topological_sort_dag_without_tasks(self):
def test_dag_naive_start_date_string(self):
DAG("DAG", schedule=None, default_args={"start_date": "2019-06-01"})
+ def test_dag_naive_start_date_constructor_default_args_string(self):
+ DAG("DAG", start_date=DEFAULT_DATE, schedule=None,
default_args={"start_date": "2019-06-01"})
Review Comment:
Is it worth asserting what the resulting start date actually is here?
In this case, since there are no tasks inside the DAG, I think the start
date property on the dag would still be DEFAULT_DATE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
