uranusjr commented on code in PR #54775:
URL: https://github.com/apache/airflow/pull/54775#discussion_r2315308480
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -1350,7 +1350,11 @@ def _create_dag_runs(self, dag_models:
Collection[DagModel], session: Session) -
)
for dag_model in dag_models:
- dag = self.dagbag.get_dag(dag_model.dag_id, session=session)
+ try:
+ dag = self.dagbag.get_dag(dag_model.dag_id, session=session)
+ except Exception:
Review Comment:
I’m not fond of this catches _everything_. Do we really expect this to fail
with many kinds of exceptions? Such a broad clause tend to lead to bugs being
difficult to investigate.
Can we limit this and the one below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
