[
https://issues.apache.org/jira/browse/AIRFLOW-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973493#comment-16973493
]
ASF GitHub Bot commented on AIRFLOW-3489:
-----------------------------------------
nuclearpinguin commented on pull request #6572: [AIRFLOW-3489] Improve json
data handling in PostgresToGcs operator
URL: https://github.com/apache/airflow/pull/6572
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3489
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
According to the issue, `PostgresToGoogleCloudStorageOperator` had a problem
with handling postgres json data type in way that would allow to import the
exported file into BigQuery. So I've added a simple check and `json.dumps`.
I've checked if after that the data could be easily transferred to BQ (using
data transfer service) and everything worked. I've added also a system test.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> PostgresToGoogleCloudStorageOperator doesn't handle PostgreSQL json properly
> -----------------------------------------------------------------------------
>
> Key: AIRFLOW-3489
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3489
> Project: Apache Airflow
> Issue Type: Bug
> Components: gcp
> Reporter: Duan Shiqiang
> Priority: Major
> Labels: bigquery
>
> PostgresToGoogleCloudStorageOperator saves json data (postgres json or jsonb)
> as native python types (i.e. dictionary) to gcs new line separated json data.
> But it generates bigquery schema for that field as data type string which
> won't work if user want to import the gcs data into bigquery.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
