Lee-W commented on code in PR #55149:
URL: https://github.com/apache/airflow/pull/55149#discussion_r2314190959
##########
airflow-core/src/airflow/ui/src/utils/hitl.ts:
##########
@@ -167,10 +167,23 @@ export const getHITLFormData = (paramsDict: ParamsSpec,
option?: string): HITLRe
};
export const getHITLState = (translate: TFunction, hitlDetail: HITLDetail) => {
- const { chosen_options: chosenOptions, options, params, response_received:
responseReceived } = hitlDetail;
+ const {
+ chosen_options: chosenOptions,
+ options,
+ params,
+ response_received: responseReceived,
+ task_instance: { state: taskInstanceState },
+ } = hitlDetail;
+
+ const isNotDeferred = taskInstanceState !== "deferred";
let stateType: [string, string] = ["responseRequired", "responseReceived"];
+ if (!responseReceived && isNotDeferred) {
+ // need to update this after unfreezing hitl.json
Review Comment:
```suggestion
// TODO: update this after unfreezing hitl.json
```
editor normally can check this
##########
airflow-core/src/airflow/ui/public/i18n/locales/en/_freeze_exemptions.json:
##########
@@ -7,6 +7,10 @@
"dag": {},
"dags": {},
"dashboard": {},
- "hitl": {},
+ "hitl": {
+ "state": {
+ "noResponseReceived": "No Response Received"
Review Comment:
I guess it only means we can skip it during the freeze. But we could add the
Taiwanese Mandarin translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
