pierrejeambrun commented on code in PR #54640:
URL: https://github.com/apache/airflow/pull/54640#discussion_r2318428384
##########
airflow-core/src/airflow/ui/src/components/Assets/AssetEvents.tsx:
##########
@@ -101,6 +107,44 @@ export const AssetEvents = ({
</Select.Root>
)}
</Flex>
+ <VStack align="start" gap={4} paddingY="4px">
+ <HStack flexWrap="wrap" gap={4}>
+ <Box w="200px">
+ <Text fontSize="xs">{translate("common:table.from")}</Text>
+ <DateTimeInput
+ onChange={(event) =>
handleFilterChange(START_DATE)(event.target.value)}
+ value={startDate}
+ />
+ </Box>
+ <Box w="200px">
+ <Text fontSize="xs">{translate("common:table.to")}</Text>
+ <DateTimeInput
+ onChange={(event) =>
handleFilterChange(END_DATE)(event.target.value)}
+ value={endDate}
+ />
+ </Box>
+ <Box w="200px">
+ <Text
fontSize="xs">{translate("common:filters.dagDisplayNamePlaceholder")}</Text>
+ <SearchBar
+ defaultValue={dagId}
+ hideAdvanced
+ hotkeyDisabled={true}
+ onChange={handleFilterChange(DAG_ID)}
+
placeHolder={translate("common:filters.dagDisplayNamePlaceholder")}
+ />
+ </Box>
+ <Box w="200px">
+ <Text
fontSize="xs">{translate("common:filters.taskIdPlaceholder")}</Text>
+ <SearchBar
+ defaultValue={taskId}
+ hideAdvanced
+ hotkeyDisabled={true}
+ onChange={handleFilterChange(TASK_ID)}
+ placeHolder={translate("common:filters.taskIdPlaceholder")}
+ />
+ </Box>
+ </HStack>
+ </VStack>
Review Comment:
You probably want to export all that, and the content of your current
useSearchParamFilters to an AssetFilters.tsx component.
This will match the file structure of other filters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
