olegkachur-e commented on PR #55064: URL: https://github.com/apache/airflow/pull/55064#issuecomment-3249860118
Hi @eladkal, Thank you for the review! > Justification for this change? - IMO, moving this call results in a bit cleaner code, removing side effect from `execute_async`, and having `convert_config_file_to_dict()` in the method we actually use it's results. - Also, it allows proper methods override for inherited operators (GKEStartPodOperator), that don't have/need config file at all. - As there is visible improvements (to some extend) and no harm (to my best understanding), I consider it as win-win. With that being said, I cautiously interpret changes as justified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
