jedcunningham commented on code in PR #55139:
URL: https://github.com/apache/airflow/pull/55139#discussion_r2319903080
##########
providers/fab/src/airflow/providers/fab/www/static/dist/743.fc7a7c6ef9d09365976e.js:
##########
Review Comment:
Why are these changing? Bad rebase maybe?
##########
airflow-core/src/airflow/models/__init__.py:
##########
@@ -124,10 +124,10 @@ def __getattr__(name):
if TYPE_CHECKING:
# I was unable to get mypy to respect a airflow/models/__init__.pyi, so
# having to resort back to this hacky method
+ from airflow.dag_processing.dagbag import DagBag
Review Comment:
Shouldn't this be in our deprecated list instead?
##########
providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py:
##########
@@ -126,7 +126,7 @@ def _iter_dags() -> Iterable[DAG]:
with create_session() as session:
yield from DBDagBag().iter_all_latest_version_dags(session=session)
else:
- from airflow.models.dagbag import DagBag
+ from airflow.models import DagBag
Review Comment:
Why? And don't we want to change the import in the block above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
