github-advanced-security[bot] commented on code in PR #55259:
URL: https://github.com/apache/airflow/pull/55259#discussion_r2324389080
##########
providers/openlineage/tests/unit/openlineage/plugins/test_utils.py:
##########
@@ -263,11 +282,20 @@
def default(self, o):
if isinstance(o, NotMixin):
+ print(f"DEBUG: JSONEncoder.default converting NotMixin to dict:
{o.__dict__}")
return o.__dict__
raise TypeError
+ result1 = redactor.redact(NotMixin())
+ print(
+ f"DEBUG: First redaction result: {result1}, password:
{getattr(result1, 'password', 'NO_PASSWORD_ATTR')}")
Review Comment:
## Clear-text logging of sensitive information
This expression logs [sensitive data (password)](1) as clear text.
[Show more
details](https://github.com/apache/airflow/security/code-scanning/529)
##########
providers/openlineage/tests/unit/openlineage/plugins/test_utils.py:
##########
@@ -263,11 +282,20 @@
def default(self, o):
if isinstance(o, NotMixin):
+ print(f"DEBUG: JSONEncoder.default converting NotMixin to dict:
{o.__dict__}")
return o.__dict__
raise TypeError
+ result1 = redactor.redact(NotMixin())
+ print(
+ f"DEBUG: First redaction result: {result1}, password:
{getattr(result1, 'password', 'NO_PASSWORD_ATTR')}")
assert redactor.redact(NotMixin()).password == "passwd"
+
monkeypatch.setattr(JSONEncoder, "default", default)
+
+ result2 = redactor.redact(NotMixin())
+ print(
+ f"DEBUG: Second redaction result: {result2}, password:
{getattr(result2, 'password', 'NO_PASSWORD_ATTR')}")
Review Comment:
## Clear-text logging of sensitive information
This expression logs [sensitive data (password)](1) as clear text.
[Show more
details](https://github.com/apache/airflow/security/code-scanning/530)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
