bbovenzi commented on code in PR #55504:
URL: https://github.com/apache/airflow/pull/55504#discussion_r2342319761
##########
airflow-core/src/airflow/ui/src/queries/useClearTaskInstances.ts:
##########
@@ -78,17 +79,23 @@ export const useClearTaskInstances = ({
),
];
- const queryKeys = [
+ // Check if this clear operation affects multiple DAG runs
+ const { include_future: includeFuture, include_past: includePast } =
variables.requestBody;
+ const affectsMultipleRuns = includeFuture === true || includePast === true;
+
+ const invalidateKeys = [
...taskInstanceKeys,
UseDagRunServiceGetDagRunKeyFn({ dagId, dagRunId }),
[useDagRunServiceGetDagRunsKey],
[useClearTaskInstancesDryRunKey, dagId],
[usePatchTaskInstanceDryRunKey, dagId, dagRunId],
UseGridServiceGetGridRunsKeyFn({ dagId }, [{ dagId }]),
- UseGridServiceGetGridTiSummariesKeyFn({ dagId, runId: dagRunId }, [{
dagId, runId: dagRunId }]),
+ affectsMultipleRuns
+ ? [useGridServiceGetGridTiSummariesKey, { dagId }]
+ : UseGridServiceGetGridTiSummariesKeyFn({ dagId, runId: dagRunId }),
Review Comment:
```suggestion
UseGridServiceGetGridTiSummariesKeyFn({ dagId, runId:
affectsMultipleRuns ? undefined : dagRunId }),
```
I feel like this is a bit simpler?
##########
airflow-core/src/airflow/ui/src/queries/useClearTaskInstances.ts:
##########
@@ -78,17 +79,23 @@ export const useClearTaskInstances = ({
),
];
- const queryKeys = [
+ // Check if this clear operation affects multiple DAG runs
+ const { include_future: includeFuture, include_past: includePast } =
variables.requestBody;
+ const affectsMultipleRuns = includeFuture === true || includePast === true;
+
+ const invalidateKeys = [
Review Comment:
Let's not rename the variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
