dabla commented on PR #55068: URL: https://github.com/apache/airflow/pull/55068#issuecomment-3286012066
So small explanation what I did in this PR. - @kaxil First of all I had to re-implement (a simplified version) of the defer_task method in TaskInstance, which was called by the schedule_tis method of the DagRun but which was commented out as start_from_trigger wasn't correctly working. @ashb proposed to try to have a common defer_task classmethod in the Trigger, and which would be re-useable across the execution api and the schedule_tis method of the DagRun, but that didn't work, as there the update of the TaskInstance is done differently, and doing it this way didn't work in the schedule_tis method as modification weren't picked up by the scheduler, thus the task instance got stuck. I even tried refreshing the ti on the session, flushing and even committing it but no avail. Thus at the moment we have a little of duplication there. I've added a TODO to keep that in mind as at the moment my main focus was to make the rendering of template fields working in triggerers. - I also had to exclude the base Trigger module from the check-sdk-imports, as there I had to import the Templater from the sdk (which was previously in airflow.template.templater). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
