KatalKavya96 commented on code in PR #55593:
URL: https://github.com/apache/airflow/pull/55593#discussion_r2345298079
##########
dev/react-plugin-tools/react_plugin_template/vite.config.ts:
##########
@@ -78,6 +78,7 @@ export default defineConfig(({ command }) => {
environment: "happy-dom",
globals: true,
mockReset: true,
+ passWithNoTests: true,
Review Comment:
> What does this flag mean/do?
It is a vitest only option that makes the run succeed when no test files are
found otherwise vitest exits with code 1. I added it because the React plugin
template and Edge plugin currently have no tests, so CI would fail.
This key is only read by Vitest and Vite ignores test so there is no
runtime/build impact on UI React plugins.
If you prefer to keep vite.config.ts build only, I can move it to the script
instead: vitest run --passWithNoTests, or drop it and add a tiny placeholder
test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
