eladkal commented on code in PR #55179:
URL: https://github.com/apache/airflow/pull/55179#discussion_r2347088639
##########
providers/microsoft/azure/tests/unit/microsoft/azure/hooks/test_msgraph.py:
##########
@@ -62,18 +63,8 @@
AzureIdentityAccessTokenProvider,
)
-try:
- import importlib.util
- if not importlib.util.find_spec("airflow.sdk.bases.hook"):
- raise ImportError
-
- BASEHOOK_PATCH_PATH = "airflow.sdk.bases.hook.BaseHook"
-except ImportError:
- BASEHOOK_PATCH_PATH = "airflow.hooks.base.BaseHook"
-
-
-class TestKiotaRequestAdapterHook:
+class TestKiotaRequestAdapterHook(Base):
Review Comment:
Can you explain this one?
Why Airflow unit test needs to inherit from upstream library base class? I
don't think we ever done that before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
