ashb commented on code in PR #55494:
URL: https://github.com/apache/airflow/pull/55494#discussion_r2348618713
##########
task-sdk/src/airflow/sdk/definitions/_internal/templater.py:
##########
@@ -178,8 +178,8 @@ def render_template(
if isinstance(value, ObjectStoragePath):
return self._render_object_storage_path(value, context, jinja_env)
- if resolve := getattr(value, "resolve", None):
- return resolve(context)
+ if isinstance(value, ResolveMixin):
Review Comment:
There was a reason initially I didn't use the ResolveMixin here -- I think
some things that need to have resolve() be called on weren't using the Mixin,
or maybe weren't using the _right_ mixin (as we had two at this point, one in
airflow-core and one in task-sdk.)
This might be okay now, but I'd like to know what testing you have done of
this, especially with mapped tasks and TaskFlow API, as I'm not sure how good
our test coverage is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
