jason810496 commented on code in PR #55257:
URL: https://github.com/apache/airflow/pull/55257#discussion_r2349342532
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py:
##########
@@ -87,6 +88,26 @@ def get_extra_links(
)
all_extra_links = {link_name: link_url or None for link_name, link_url in
sorted(all_extra_link_pairs)}
+ extra_link_records = (
+ session.query(XCom)
+ .filter(
+ XCom.dag_id == dag_id,
+ XCom.run_id == dag_run_id,
+ XCom.task_id == task_id,
+ XCom.map_index == map_index,
+ XCom.key.like("extra_link:%"),
Review Comment:
Would it be better to name the prefix as `_dynamic_link` ( or
`_runtime_link` ) and make it as a constant in XCom module?
Since the _extra_link_ we introduce in this PR can be set in the runtime,
and #55194 is for solving the _static_ link ( already define in the operator
level ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
