sidshas03 opened a new pull request, #55686: URL: https://github.com/apache/airflow/pull/55686
## Fix AthenaSQLHook to handle hook_params properly **Fixes #55678** ### Problem `SQLValueCheckOperator` throws `TypeError: AwsGenericHook.__init__() got an unexpected keyword argument 's3_staging_dir'` when used with `AthenaSQLHook`. ### Root Cause Athena-specific parameters from connection `extra_dejson` (like `s3_staging_dir`, `work_group`) are passed as `hook_params` to `AthenaSQLHook`, but `AwsBaseHook` only accepts AWS-specific parameters. ### Solution Extract Athena-specific parameters from `kwargs` using `kwargs.pop()` before passing to parent `AwsBaseHook` constructor. ### Changes - **Modified**: `AthenaSQLHook.__init__()` to extract Athena parameters - **Updated**: `_get_conn_params()` and `get_conn()` to use extracted parameters - **Added**: Comprehensive tests for hook_params handling ### Result ✅ `SQLValueCheckOperator` now works with `AthenaSQLHook` ✅ Backward compatible ✅ Follows pattern used by other SQL hooks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
