ashb opened a new pull request, #55716:
URL: https://github.com/apache/airflow/pull/55716

   We were trying to be "smart" about what interface we listened on, but that
   isn't really needed, and passing an empty host achieves the same effect:
   
   ```
   $ netstat -antlp  | grep 8793
   tcp        0      0 0.0.0.0:8793            0.0.0.0:*               LISTEN   
   85699/airflow serve
   tcp6       0      0 :::8793                 :::*                    LISTEN   
   85699/airflow serve
   ```
   
   The existing approach was working fine for most people (including myself) it
   was working fine and listening on ipv6 and v4 wildcard interfaces as 
expected,
   but some Docker/container set ups this was not the case, and despite 
Dualstack
   saying True, listening on `::` ended up _only_ listening on IPv6, but the
   entry in `/etc/hosts` in the container only had an entry for the IPv4 address
   of the pod, which we weren't listening on, so log requests would fail.
   
   Which is all a round about way of saying "doing less works better" 😀
   
   (We also don't need the getattr+lambda anymore, as that was to support Python
   <= 3.7!)
   
   Fixes #55470
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to