ephraimbuddy commented on code in PR #54505:
URL: https://github.com/apache/airflow/pull/54505#discussion_r2353724934
##########
task-sdk/src/airflow/sdk/exceptions.py:
##########
@@ -18,16 +18,33 @@
from __future__ import annotations
import enum
+from http import HTTPStatus
from typing import TYPE_CHECKING, Any
-from airflow.exceptions import AirflowException
from airflow.sdk import TriggerRule
if TYPE_CHECKING:
+ from collections.abc import Collection
+
+ from airflow.sdk.definitions.asset import AssetNameRef, AssetUniqueKey,
AssetUriRef
from airflow.sdk.execution_time.comms import ErrorResponse
-class AirflowDagCycleException(AirflowException):
+class AirflowSDKException(Exception):
Review Comment:
AirflowException would confuse in usage. I chose it so we can differentiate
it from AirflowException in core. Also, the AirflowSDKException is only used as
a base class for the other exceptions. It's not used in SDK. We will add a
pre-commit to ban the use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
